Fixes for Github Issue #516, #515 and #493 #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes code formatting improvements and fixes a critical indentation bug in the upload() method.
- Fixed indentation of the
return successstatement to ensure it executes after the try-except-finally block completes - Added blank lines for improved code formatting around the
FatalErrorclass definition
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MichaelGHSeg
previously approved these changes
Nov 12, 2025
neelkanth-kaushik
changed the title
Merging Github Issue 515 and Github Issue 516 into single PR
neelkanth-kaushik
changed the title
neelkanth-kaushik
changed the title
neelkanth-kaushik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the library to version 2.3.5, addressing three GitHub issues and improving error handling and logging in the analytics consumer. The most important changes are grouped below:
Github Issues Fixed in this Pull Request:
Bug fixes and version update:
2.3.5insegment/analytics/version.pyand documented the release and inHISTORY.md.segment/analytics/consumer.pyby adding detailed debug logs for each retry attempt and logging an error when all retries are exhausted.return successout of the finally block insegment/analytics/consumer.pyat Line 84.segment/analytics/request.pyto avoid duplicate logs when exceptions are raised.